-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(planner): add tips for wrong usage of semi or anti join #13948
Merged
Dousir9
merged 22 commits into
databendlabs:main
from
Dousir9:add_tips_for_wrong_usage_of_semi_anti_join
Dec 8, 2023
Merged
chore(planner): add tips for wrong usage of semi or anti join #13948
Dousir9
merged 22 commits into
databendlabs:main
from
Dousir9:add_tips_for_wrong_usage_of_semi_anti_join
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
this PR only has small changes that no need to record, like coding styles.
label
Dec 7, 2023
…_for_wrong_usage_of_semi_anti_join
BohuTANG
reviewed
Dec 7, 2023
src/query/sql/src/executor/physical_plans/physical_hash_join.rs
Outdated
Show resolved
Hide resolved
andylokandy
reviewed
Dec 7, 2023
src/query/sql/src/executor/physical_plans/physical_hash_join.rs
Outdated
Show resolved
Hide resolved
andylokandy
reviewed
Dec 7, 2023
src/query/sql/src/executor/physical_plans/physical_hash_join.rs
Outdated
Show resolved
Hide resolved
src/query/sql/src/executor/physical_plans/physical_hash_join.rs
Outdated
Show resolved
Hide resolved
src/query/sql/src/executor/physical_plans/physical_hash_join.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy Lok <[email protected]>
Co-authored-by: Andy Lok <[email protected]>
Co-authored-by: Andy Lok <[email protected]>
waiting for #13951 |
…_for_wrong_usage_of_semi_anti_join
BohuTANG
reviewed
Dec 8, 2023
src/query/sql/src/executor/physical_plans/physical_hash_join.rs
Outdated
Show resolved
Hide resolved
xudong963
reviewed
Dec 8, 2023
xudong963
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
This change is