feat(cluster): support compression for query flight data #13934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
sundy-li
reviewed
Dec 6, 2023
zhang2014
added
ci-benchmark
Docker Image for PR
|
BohuTANG
reviewed
Dec 6, 2023
sundy-li
approved these changes
Dec 6, 2023
BohuTANG
added
ci-benchmark
Docker Image for PR
|
zhang2014
added
ci-benchmark
Docker Image for PR
|
BohuTANG
reviewed
Dec 7, 2023
Comment on lines
+28
to
+31
| pub enum FlightCompression { | ||
| Lz4, | ||
| Zstd, | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub enum FlightCompression { | |
| Lz4, | |
| Zstd, | |
| } | |
| pub enum FlightCompression { | |
| LZ4, | |
| ZSTD, | |
| } |
There was a problem hiding this comment.
this's the warehouse of pr-13934-1b647cd version
There was a problem hiding this comment.
From the settings show, user may set as:
set query_flight_compression='Lz4';
not
set query_flight_compression='LZ4';
But possible values are:
possible_values: Some(vec!["None", "LZ4", "ZSTD"]),
Updated:
It's only a display issue, the query_flight_compression is case insensitive.
BohuTANG
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
feat(cluster): support compression for query flight data
This change is