Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max_active_session does not work for http handler. #13931

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Dec 5, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  • Closes #issue

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 5, 2023
@youngsofun youngsofun marked this pull request as draft December 5, 2023 16:26
@youngsofun youngsofun requested review from ariesdevil and removed request for ariesdevil December 5, 2023 16:26
@youngsofun youngsofun marked this pull request as ready for review December 5, 2023 16:52
@youngsofun youngsofun force-pushed the session branch 4 times, most recently from b9bdd9f to 106a17f Compare December 5, 2023 17:19
@youngsofun
Copy link
Member Author

youngsofun commented Dec 6, 2023

  1. new impl not longer add dummy session to active sessions unless it is later upgraded. otherwise multi concurrent dummy sessions will occupy the slots for normal sessions, especially make it hard to test .
  2. add tests
  3. test for mysql handler changed. now allow num_sessions == max_sessions, and we always check <= before add.

@zhang2014 @ariesdevil

@BohuTANG BohuTANG merged commit aa9b7d8 into databendlabs:main Dec 6, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants