feat(query): Add warnings in the query response #13918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
|
lgtm， only some tests need fix |
youngsofun
approved these changes
Dec 5, 2023
flaneur2020
force-pushed
the
add-warnings-to-query-ctx
branch
from
8827c04 to
a814b63
Compare
youngsofun
reviewed
Dec 6, 2023
youngsofun
reviewed
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
this PR added an extra
warningsfield in the http query response. whenever we got errors which hope to be swallowed, we can transform it into a warning and pass the warning message to the driver by thiswarningsfield.fixes #13413
This change is