Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planner): fix push down filter through eval scalar #13232

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Oct 12, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Sometime a filter predicate will be incorrectly pushed down to table scan, for example:

select * from (select a as b from t) where b = 1

In this case, the Scan operator cannot exploit the predicate b = 1 to prune data.


This change is Reviewable

@leiysky leiysky added the A-planner Area: planner/optimizer label Oct 12, 2023
@leiysky leiysky requested a review from andylokandy October 12, 2023 12:42
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 0:46am

@leiysky leiysky changed the title fix(planner): fix push down filter through eval scalar bugfix(planner): fix push down filter through eval scalar Oct 12, 2023
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 12, 2023
@leiysky leiysky changed the title bugfix(planner): fix push down filter through eval scalar fix(planner): fix push down filter through eval scalar Oct 12, 2023
@andylokandy andylokandy added this pull request to the merge queue Oct 12, 2023
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 12, 2023
@BohuTANG BohuTANG merged commit 076e113 into databendlabs:main Oct 12, 2023
59 checks passed
@leiysky leiysky deleted the fix-push-down-filter branch October 12, 2023 14:37
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-planner Area: planner/optimizer pr-bugfix this PR patches a bug in codebase
Projects
Status: 📕Done
Development

Successfully merging this pull request may close these issues.

3 participants