Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix predicate_index and not matched null cast #13208

Merged
merged 9 commits into from
Oct 12, 2023
Merged

fix: fix predicate_index and not matched null cast #13208

merged 9 commits into from
Oct 12, 2023

Conversation

JackTan25
Copy link
Contributor

@JackTan25 JackTan25 commented Oct 11, 2023 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. fix not match null cast
  2. fix predicate index error
    Summary about this PR
  • Closes #issue

This change is Reviewable

@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 1:55am

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 11, 2023
@JackTan25 JackTan25 requested a review from ariesdevil October 11, 2023 11:19
@JackTan25 JackTan25 closed this Oct 11, 2023
@JackTan25 JackTan25 reopened this Oct 11, 2023
@JackTan25 JackTan25 marked this pull request as draft October 11, 2023 11:31
@JackTan25 JackTan25 marked this pull request as ready for review October 11, 2023 11:46
@JackTan25 JackTan25 added ci-benchmark Benchmark: run all test ci-cloud Build docker image for cloud test and removed ci-benchmark Benchmark: run all test labels Oct 11, 2023
@JackTan25 JackTan25 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Oct 11, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13208-605f803

note: this image tag is only available for internal use,
please check the internal doc for more details.

2 similar comments
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13208-605f803

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13208-605f803

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report

@dantengsky
Copy link
Member

askbend:summary

@dantengsky dantengsky added this pull request to the merge queue Oct 12, 2023
Merged via the queue into databendlabs:main with commit 1a8b79d Oct 12, 2023
59 checks passed
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
@JackTan25 @andylokandy
fix: fix predicate_index and not matched null cast (databendlabs#13208)
c5b1c79 
* fix predicate_index and not matched null cast

* use u32 instead of uszie

* fix test

* add log

* use u64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

@ariesdevil ariesdevil ariesdevil approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackTan25 @dantengsky @ariesdevil