fix: fix the invalid memory write bug for aggregating index. #13165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ariesdevil
approved these changes
Oct 10, 2023
sundy-li
reviewed
Oct 10, 2023
src/query/service/src/pipelines/processors/transforms/aggregator/transform_aggregate_partial.rs
Outdated
Show resolved
Hide resolved
sundy-li
approved these changes
Oct 10, 2023
zhang2014
approved these changes
Oct 10, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
RinChanNOWWW
force-pushed
the
fix-agg-index
branch
from
fd641c0 to
7083c76
Compare
RinChanNOWWW
force-pushed
the
fix-agg-index
branch
from
a91ab3a to
aa4b60f
Compare
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
…dlabs#13165) * fix: fix the invalid memory write bug for aggregating index. * Remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
UPDATE: the memory bug was already fixed by #13153. This PR becomes only providing some unit tests for the bug case.
The orginal summary:
We should hold a owned memory for deserializing aggregating index state instead of use the memory owned by the hashtable.
Because the hashtable will be moved out when spilling and we will lose the control of the memory.
This change is