refactor: meta-service: re-implement export with Stream #13097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
pr-refactor
|
@everpcpc |
everpcpc
approved these changes
Oct 7, 2023
- Updated the `export()` function in `grpc_service.rs` to use crate `futures-async-stream`, changed return type of the function to use a `BoxStream` that yields a series of JSON strings, instead of returning a big `Vec<String>`. This allows for more efficient handling of asynchronous streams, which can provide performance improvements. Note that `export(self: Arc<Sefl>)` takes an `Arc<Self>` as argument because the generated `gRPC` stream signature requires a `'static` lifetime. As a result, the `export(&self)` can not be used: ``` type ExportStream: Stream<Item = Result<_, _>> + Send + 'static; ``` - Add dependency crate `futures-async-stream`; - Enable unstable feature `#![feature(generators)]` for building a `Stream` from a generator(`yield ...`);
drmingdrmer
force-pushed
the
42-export-stream-2
branch
from
75037af to
0ded016
Compare
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
…#13097) - Updated the `export()` function in `grpc_service.rs` to use crate `futures-async-stream`, changed return type of the function to use a `BoxStream` that yields a series of JSON strings, instead of returning a big `Vec<String>`. This allows for more efficient handling of asynchronous streams, which can provide performance improvements. Note that `export(self: Arc<Sefl>)` takes an `Arc<Self>` as argument because the generated `gRPC` stream signature requires a `'static` lifetime. As a result, the `export(&self)` can not be used: ``` type ExportStream: Stream<Item = Result<_, _>> + Send + 'static; ``` - Add dependency crate `futures-async-stream`; - Enable unstable feature `#![feature(generators)]` for building a `Stream` from a generator(`yield ...`);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
refactor: meta-service: re-implement export with Stream
Updated the
export()function ingrpc_service.rsto use cratefutures-async-stream, changed return type of the function to use aBoxStreamthat yields a series of JSON strings, instead of returninga big
Vec<String>.This allows for more efficient handling of asynchronous streams, which
can provide performance improvements.
Note that
export(self: Arc<Sefl>)takes anArc<Self>as argumentbecause the generated
gRPCstream signature requires a'staticlifetime. As a result, the
export(&self)can not be used:Add dependency crate
futures-async-stream;Enable unstable feature
#![feature(generators)]for building aStreamfrom a generator(yield ...);Changelog
Related Issues
This change is