Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor pushdown::TopK. #13095

Merged
merged 3 commits into from
Oct 7, 2023
Merged

chore: refactor pushdown::TopK. #13095

merged 3 commits into from
Oct 7, 2023

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Oct 7, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Rename order_by to field.
  • Remove column_id in TopK as it already exist in field.
  • Add leaf_id for parquet table to use.
  • Support sub column of nested type in topk pushdown.

This change is Reviewable

@RinChanNOWWW RinChanNOWWW requested a review from sundy-li October 7, 2023 03:43
@vercel
Copy link

vercel bot commented Oct 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 8:27am

@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review October 7, 2023 06:49
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 7, 2023
@RinChanNOWWW RinChanNOWWW requested a review from b41sh October 7, 2023 06:49
@BohuTANG BohuTANG merged commit 6f76ae6 into databendlabs:main Oct 7, 2023
58 checks passed
@RinChanNOWWW RinChanNOWWW deleted the topk branch October 7, 2023 09:20
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
@RinChanNOWWW @andylokandy
chore: refactor pushdown::TopK. (databendlabs#13095)
61729f9 
* chore: refactor topk.

* Support inner column as topk key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh b41sh approved these changes

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RinChanNOWWW @b41sh @sundy-li @BohuTANG