Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tweak table data life-cycle related sql stmts #13015

Merged
merged 12 commits into from
Sep 27, 2023

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Sep 26, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • drop table all
  • truncate table purge

Remove the purge logic from the above statements, and adjust the syntax accordingly.


This change is Reviewable

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2023 7:05am

@zhyass zhyass marked this pull request as draft September 26, 2023 03:11
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 26, 2023
@zhyass zhyass added the ci-benchmark Benchmark: run all test label Sep 26, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13015-6b19675

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions
Copy link
Contributor

@zhyass zhyass marked this pull request as ready for review September 26, 2023 17:37
@zhyass zhyass requested review from BohuTANG, dantengsky, TCeason and soyeric128 and removed request for BohuTANG September 26, 2023 17:37
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify with Show create table and system.tables LGTM

@zhyass zhyass marked this pull request as draft September 27, 2023 04:12
@zhyass zhyass marked this pull request as ready for review September 27, 2023 04:46
@zhyass zhyass merged commit e14dc7c into databendlabs:main Sep 27, 2023
58 checks passed
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Oct 12, 2023
BohuTANG pushed a commit that referenced this pull request Oct 12, 2023
…l stmts (#13015)" (#13223)

* Revert "feat: tweak table data life-cycle related sql stmts (#13015)"

This reverts commit e14dc7c.

* remove `truncate ... purge`

* clean up

* update doc of ddl-truncate-table
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* feat: tweak table data life-cycle related sql stmts

* fix test

* fix test

* remove drop all

* fix test

* fix docs

* fix test

* revert transient table

* fix test
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
…l stmts (databendlabs#13015)" (databendlabs#13223)

* Revert "feat: tweak table data life-cycle related sql stmts (databendlabs#13015)"

This reverts commit e14dc7c.

* remove `truncate ... purge`

* clean up

* update doc of ddl-truncate-table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: tweak table data life-cycle related sql stmts
3 participants