feat: support histogram for equal condition #11297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dousir9
reviewed
May 5, 2023
| let bucket_min = hist.buckets[idx - 1].upper_bound().to_double()?; | ||
| let bucket_max = bucket.upper_bound().to_double()?; | ||
| // If the bucket max is less than min, skip it | ||
| if bucket_max < min { |
There was a problem hiding this comment.
Since bucket_max(upper_bound) is derived from col_stat.min and col_stat.max, so I think bucket_max < min will always be false.
Dousir9
reviewed
May 5, 2023
| let bucket_min = hist.buckets[idx - 1].upper_bound().to_double()?; | ||
| let bucket_max = bucket.upper_bound().to_double()?; | ||
| // If the bucket max is less than min, skip it | ||
| if bucket_max < const_value || bucket.num_distinct() == 0.0 { |
There was a problem hiding this comment.
bucket_max <= const_value, because the bucket range is [bucket_min, bucket_max).
| continue; | ||
| } | ||
| // If the bucket min is greater than max, stop iteration | ||
| if bucket_min >= const_value { |
|
Will continue the ticket after #11332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Closes #issue
This change is