Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configurable liveness probe timeout #918

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

bnaul
Copy link
Contributor

@bnaul bnaul commented Oct 31, 2024

Fixes #917

Plain helm install:

Liveness:      http-get http://:8080/healthz delay=0s timeout=1s period=10s #success=1 #failure=3

With --set livenessProbe.timeoutSeconds=5:

Liveness:      http-get http://:8080/healthz delay=0s timeout=5s period=10s #success=1 #failure=3

@@ -54,6 +54,9 @@ affinity: {} # Affinity

priorityClassName: null # Priority class

livenessProbe:
timeoutSeconds: 1
Copy link
Contributor Author

@bnaul bnaul Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobtomlinson I would probably say bump the default but no strong preference, figured I'd start with the same value and just make it configurable

Suggested change
timeoutSeconds: 1
timeoutSeconds: 5

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Happy to bump the default value.

@jacobtomlinson
Copy link
Member

Hmm it won't let me commit the suggestion to change it to 5. Could you update the PR?

@bnaul
Copy link
Contributor Author

bnaul commented Nov 5, 2024

@jacobtomlinson done, plus updated the README

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you!

@jacobtomlinson jacobtomlinson merged commit f30da72 into dask:main Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default helm liveness probe timeout (1s) is too short
2 participants