-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add configurable liveness probe timeout #918
Conversation
@@ -54,6 +54,9 @@ affinity: {} # Affinity | |||
|
|||
priorityClassName: null # Priority class | |||
|
|||
livenessProbe: | |||
timeoutSeconds: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobtomlinson I would probably say bump the default but no strong preference, figured I'd start with the same value and just make it configurable
timeoutSeconds: 1 | |
timeoutSeconds: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Happy to bump the default value.
dask_kubernetes/operator/deployment/helm/dask-kubernetes-operator/values.yaml
Outdated
Show resolved
Hide resolved
…tor/values.yaml Co-authored-by: Jacob Tomlinson <[email protected]>
Hmm it won't let me commit the suggestion to change it to |
@jacobtomlinson done, plus updated the README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thank you!
Fixes #917
Plain helm install:
With
--set livenessProbe.timeoutSeconds=5
: