Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loadBalancer attribute name #908

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix loadBalancer attribute name #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dask_kubernetes/operator/controller/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ async def handle_scheduler_service_status(
assert namespace
# If the Service is a LoadBalancer with no ingress endpoints mark the cluster as Pending
if spec["type"] == "LoadBalancer" and not len(
status.get("load_balancer", {}).get("ingress", [])
status.get("loadBalancer", {}).get("ingress", [])
):
phase = "Pending"
# Otherwise mark it as Running
Expand Down
4 changes: 2 additions & 2 deletions dask_kubernetes/operator/networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ async def get_external_address_for_scheduler_service(
"""Take a service object and return the scheduler address."""
if service.spec.type == "LoadBalancer":
port = _get_port(service, port_name)
lb = service.status.load_balancer.ingress[0]
host = lb.hostname or lb.ip
lb = service.status.loadBalancer.ingress[0]
host = lb.get("hostname", None) or lb.ip
elif service.spec.type == "NodePort":
port = _get_port(service, port_name, is_node_port=True)
nodes = await kr8s.asyncio.get("nodes")
Expand Down
Loading