Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port number when use NodePort (#806) #808

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Fix port number when use NodePort (#806) #808

merged 2 commits into from
Sep 4, 2023

Conversation

dbalabka
Copy link
Contributor

Here is an explanation why we have to use node_port instead of port when service type is NodePort: https://stackoverflow.com/a/41510604/983577

@dbalabka dbalabka mentioned this pull request Aug 29, 2023
Closed
dbalabka

This comment was marked as duplicate.

Sign in to view

jacobtomlinson
jacobtomlinson approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great many thanks!

@jacobtomlinson jacobtomlinson merged commit 32a4f61 into dask:main Sep 4, 2023
18 checks passed
@dbalabka
Copy link
Contributor Author

dbalabka commented Sep 6, 2023 •
edited
Loading

@jacobtomlinson, thank you for responding so promptly. It is a pleasure to work with you! Looking forward to test a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbalabka @jacobtomlinson