Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross post dask detrending from xarray blog #176

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

scharlottej13
Copy link
Contributor

Cross-posting @phofl's xarray blog post.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for dask-blog ready!

Name Link
🔨 Latest commit cd83400
🔍 Latest deploy log https://app.netlify.com/sites/dask-blog/deploys/673f763b06ec170008665ae0
😎 Deploy Preview https://deploy-preview-176--dask-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GenevieveBuckley
Copy link
Collaborator

According to the logs, the build is failing because it needs ruby >=3.0.0 for some of the dependencies to install correctly.

We could edit this line of the gemfile to try and fix that. (I think currently RUBY_VERSION is not actually defined anywhere, and so it's just making a wild guess and trying to install ruby 2.7.2 for us)

ruby RUBY_VERSION

@jacobtomlinson
Copy link
Member

Thanks for cross-posting here @scharlottej13. And thanks for investigating the build failure @GenevieveBuckley.

I've pulled in the build fix from #177, so things should build successfully now.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the figures are rendering a bit big. Could you take a look at set a maximum width @scharlottej13?

You might need to use HTML <img src="..." width="100%" /> or something along those lines instead of the markdown syntax for images.

@scharlottej13
Copy link
Contributor Author

Thanks @jacobtomlinson and @GenevieveBuckley!

I think these image sizes look much more reasonable

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scharlottej13

(And thanks @GenevieveBuckley @jacobtomlinson for reviewing)

@jrbourbeau jrbourbeau merged commit 2c936d5 into dask:gh-pages Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants