-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Increase test coverage --- body_builder.dart was the target. Process: Replaced all `coverage-ignore-block(suite):` comments with throws and ran `python3 tools/test.py -n cfe-strong-linux language/`, copying (and modifying) representative tests from `langauge` that covered new stuff (i.e. threw in the modified version). Then undid the throw changes, and redid the coverage marking. Change-Id: Ie08dc6fcd70cd3722b68c38bf2a152d03aae7885 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378705 Commit-Queue: Jens Johansen <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
- Loading branch information
Showing
138 changed files
with
3,101 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| void foo() { | ||
| print(#Bla); // OK | ||
| print(#!); // Error | ||
| } |
22 changes: 22 additions & 0 deletions
22
pkg/front_end/testcases/coverage/bad_literal_symbol.dart.strong.expect
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| library; | ||
| // | ||
| // Problems in library: | ||
| // | ||
| // pkg/front_end/testcases/coverage/bad_literal_symbol.dart:7:10: Error: Expected an identifier, but got '!'. | ||
| // Try inserting an identifier before '!'. | ||
| // print(#!); // Error | ||
| // ^ | ||
| // | ||
| import self as self; | ||
| import "dart:core" as core; | ||
|
|
||
| static method foo() → void { | ||
| core::print(#C1); | ||
| core::print(invalid-expression "pkg/front_end/testcases/coverage/bad_literal_symbol.dart:7:9: Error: This couldn't be parsed. | ||
| print(#!); // Error | ||
| ^"!); | ||
| } | ||
|
|
||
| constants { | ||
| #C1 = #Bla | ||
| } |
22 changes: 22 additions & 0 deletions
22
pkg/front_end/testcases/coverage/bad_literal_symbol.dart.strong.modular.expect
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| library; | ||
| // | ||
| // Problems in library: | ||
| // | ||
| // pkg/front_end/testcases/coverage/bad_literal_symbol.dart:7:10: Error: Expected an identifier, but got '!'. | ||
| // Try inserting an identifier before '!'. | ||
| // print(#!); // Error | ||
| // ^ | ||
| // | ||
| import self as self; | ||
| import "dart:core" as core; | ||
|
|
||
| static method foo() → void { | ||
| core::print(#C1); | ||
| core::print(invalid-expression "pkg/front_end/testcases/coverage/bad_literal_symbol.dart:7:9: Error: This couldn't be parsed. | ||
| print(#!); // Error | ||
| ^"!); | ||
| } | ||
|
|
||
| constants { | ||
| #C1 = #Bla | ||
| } |
5 changes: 5 additions & 0 deletions
5
pkg/front_end/testcases/coverage/bad_literal_symbol.dart.strong.outline.expect
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| library; | ||
| import self as self; | ||
|
|
||
| static method foo() → void | ||
| ; |
22 changes: 22 additions & 0 deletions
22
pkg/front_end/testcases/coverage/bad_literal_symbol.dart.strong.transformed.expect
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| library; | ||
| // | ||
| // Problems in library: | ||
| // | ||
| // pkg/front_end/testcases/coverage/bad_literal_symbol.dart:7:10: Error: Expected an identifier, but got '!'. | ||
| // Try inserting an identifier before '!'. | ||
| // print(#!); // Error | ||
| // ^ | ||
| // | ||
| import self as self; | ||
| import "dart:core" as core; | ||
|
|
||
| static method foo() → void { | ||
| core::print(#C1); | ||
| core::print(invalid-expression "pkg/front_end/testcases/coverage/bad_literal_symbol.dart:7:9: Error: This couldn't be parsed. | ||
| print(#!); // Error | ||
| ^"!); | ||
| } | ||
|
|
||
| constants { | ||
| #C1 = #Bla | ||
| } |
1 change: 1 addition & 0 deletions
1
pkg/front_end/testcases/coverage/bad_literal_symbol.dart.textual_outline.expect
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| void foo() {} |
1 change: 1 addition & 0 deletions
1
pkg/front_end/testcases/coverage/bad_literal_symbol.dart.textual_outline_modelled.expect
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| void foo() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| // Based on tests/language/compile_time_constant/r_test.dart | ||
|
|
||
| const x = throw "x"; // Error |
Oops, something went wrong.