Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_builder] Don't use FFIgen in test #843

Merged
merged 3 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ void main() async {
test('right asset id but other directory', timeout: longTimeout, () async {
await inTempDir((tempUri) async {
final packageUri = tempUri.resolve('different_root_dir/');
await copyTestProjects(
targetUri: tempUri,
);
await copyTestProjects(
sourceUri: testDataUri.resolve('native_add/'),
targetUri: packageUri,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ void main() async {
logger,
dartExecutable,
capturedLogs: logMessages,
runPackageName: 'ffigen',
runPackageName: 'some_dev_dep',
);
expect(result.assets, isEmpty);
expect(result.dependencies, isEmpty);
Expand Down
2 changes: 2 additions & 0 deletions pkgs/native_assets_builder/test/data/manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
- package_reading_metadata/pubspec.yaml
- package_with_metadata/build.dart
- package_with_metadata/pubspec.yaml
- some_dev_dep/bin/some_dev_dep.dart
- some_dev_dep/pubspec.yaml
- wrong_build_output/build.dart
- wrong_build_output/pubspec.yaml
- wrong_build_output_2/build.dart
Expand Down
2 changes: 2 additions & 0 deletions pkgs/native_assets_builder/test/data/native_add/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ dependencies:
dev_dependencies:
ffigen: ^8.0.2
lints: ^3.0.0
some_dev_dep:
path: ../some_dev_dep/
test: ^1.23.1
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

void main() {
print('Hello world!');
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: some_dev_dep
description: Has a bin script that can be run from the context of other root packages.
version: 0.1.0

publish_to: none

environment:
sdk: '>=3.0.0 <4.0.0'