[infra] script to change deps to path dependencies #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type-infra
dcharkes
commented
Nov 20, 2023
| } | ||
|
|
||
| const packagesToPin = { | ||
| 'native_assets_builder', |
There was a problem hiding this comment.
@HosseinYousefi Would this be useful for package:jnigen and package:jni as well? So that jnigen is both tested against the published package:jni and against the package:jni in the repo?
There was a problem hiding this comment.
Usually we release both of the versions together, expecting users to use the latests of both, so I don't think it's necessary.
HosseinYousefi
approved these changes
Nov 21, 2023
| } | ||
|
|
||
| const packagesToPin = { | ||
| 'native_assets_builder', |
There was a problem hiding this comment.
Usually we release both of the versions together, expecting users to use the latests of both, so I don't think it's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script that rewrites pubspecs to use path dependencies between the
native_*packages in this repo.This might be too strict if we ever need to breaking changes across multiple packages, in that case we can temporarily disable this.
Closes: #80