Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Try fix coveralls #813

Merged
merged 4 commits into from
Nov 20, 2023
Merged

[infra] Try fix coveralls #813

merged 4 commits into from
Nov 20, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Nov 20, 2023

Try to fix the first issue mentioned in: #812

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Nov 20, 2023
Copy link

github-actions bot commented Nov 20, 2023

Coverage Status

coverage: 91.656% (-6.5%) from 98.152%
when pulling 932ffa4 on try-fix-coveralls
into 5dca10e on main.

@dcharkes
Copy link
Collaborator Author

Okay now at least the flag-names show up for all workflows:

So apparently it requires parallel: true.

Maybe we should try and merge this PR to see if things get carried forwards afterwards.

If that doesn't work, we can try the manual carry forward flags from https://coveralls.io/better-monorepo-support. But that documentation page says it shouldn't be necessary.

@dcharkes dcharkes enabled auto-merge (squash) November 20, 2023 12:45
@dcharkes dcharkes merged commit 7d9fbf3 into main Nov 20, 2023
23 checks passed
@dcharkes dcharkes deleted the try-fix-coveralls branch November 20, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants