Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_assets_cli] Make package:test dev dep #1799
[native_assets_cli] Make package:test dev dep #1799
Changes from 3 commits
0ad8e81
9b1073c
2074230
a157dbe
e4f94f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this class should be part of the public API. I don't believe users should catch it. So maybe it should an
Error
instead?Error
itself has a message, so we could even throwError
instead of_VerificationError
.Or do you believe users should catch this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I looked into this a bit more.
Error
itself doesn't have a message; its subclasses do. None of those look like great candidates to throw, and, it looks likeexpect
throws an Exception, not an Error, so I think we should do the same.I updated this to be a
ValidationFailure
, implementing an Exception and not an error. I also moved it to a place in the code where it won't be public API.