[jnigen] Use dollar signs for nested class name separator #1791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Bar
class defined inside theFoo
class in Java likeclass Foo { class Bar {} }
used to be generated asFoo_Bar
, but we can have a class namedFoo_Bar
, now we generate it asFoo$Bar
.We can (although very rare – rarer than using underscores) have a class named
Foo$Bar
that is not nested, this will be generated asFoo$$Bar
as all dollar signs that are pre-existing in Java code will be replaced by 2 dollar signs. So we continue not to have any collisions.I should mention that it's impossible to have both a nested
Bar
insideFoo
and a class namedFoo$Bar
in the same package in Java because they will share the same binary name ofcom.package.Foo$Bar
, so choosing$
is better than_
because of this as well.Closes #1516.