-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [ffigen] Event ordering test #1781
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
I'm not sure if the callbacks are coming on the same thread but only one call should be in-flight at once because I'm setting maxConcurrentOperationCount to 1. I cannot reproduce this issue either but the traceback is clearly a real one. |
Trying to repro dart-lang/http#1413, but not having much success.
This test calls 10 different listeners in sequence, 100 times each, on a background thread, and verifies that the Dart isolate sees them all arrive in order. I was expecting it to fail since blocks with different signatures currently use different listeners, so have different receive ports under the hood. But it seems that even messages sent to different ports maintain their order.
The test passes whether it's written using listener blocks, or protocol methods.
@brianquinlan how sure are you that all the protocol methods are being invoked on the same thread?
#1760