[native_toolchain_c] Use 16 kb pages for Android by default #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
dcharkes
changed the title
mkustermann
approved these changes
Nov 20, 2024
| @@ -67,6 +67,9 @@ void main() { | |||
| .firstWhere((e) => e.contains('file format')); | |||
| expect(machine, contains(objdumpFileFormat[target])); | |||
| } | |||
| if (linkMode == DynamicLoadingBundled()) { | |||
| await expectPageSize(libUri, 16 * 1024); | |||
There was a problem hiding this comment.
Do we have evidence of users running into this issue?
Not all users will use package:native_toolchain_c, some may ship binaries, etc. So we could add build output validation for this that will apply to all code assets.
if (targetOS == OS.android && androidVersion >= ...) {
ensurePageSizeIs16Kb(...);
}
somewhere in
There was a problem hiding this comment.
Do we have evidence of users running into this issue?
plugin_ffiusers were running into this: fix: support android 15 16k page size for template plugin_ffi flutter/flutter#155508- I'm running into this locally with the latest version of the emulator on Linux and MacOS.
So we could add build output validation for this that will apply to all code assets.
We're not mandating readelf or objdump currently. Flutter provides access to a compiler, linker, and archiver via cCompiler. But we don't have something similar for commandline utilities at the moment.
There was a problem hiding this comment.
androidVersion
We don't have an android version. Only a minAndroidSdkVersion. But the minAndroidSdk doesn't matter, something compiled with a lower min SDK trying to run on Android 15 will still fail to load the dylib if the page-size is smaller than 16kb.
|
Thanks @mkustermann! I've filed #1741 to add the command-line utilities somewhere so that we can rely on them and report users via a doctor command if the utilities are not there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1611