-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [ffigen] Trying to fix global_test flake #1674
Draft
liamappelbe
wants to merge
9
commits into
main
Choose a base branch
from
more_global_flake
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type-infra
A repository infrastructure change or enhancement
label
Oct 23, 2024
liamappelbe
changed the title
Still debugging global flake
[WIP] Still debugging global flake
Oct 24, 2024
liamappelbe
force-pushed
the
more_global_flake
branch
from
December 18, 2024 03:45
3821021
to
fdc7c0a
Compare
github-actions
bot
removed
the
type-infra
A repository infrastructure change or enhancement
label
Dec 18, 2024
liamappelbe
changed the title
[WIP] Still debugging global flake
[ffigen] Fix global_test flake (finally!)
Dec 18, 2024
Of course, as soon as I put this PR out for review, it starts flaking again 😩 |
liamappelbe
changed the title
[ffigen] Fix global_test flake (finally!)
WIP: [ffigen] Trying to fix global_test flake
Dec 18, 2024
github-actions
bot
added
the
type-infra
A repository infrastructure change or enhancement
label
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global_test and global_native_test are exactly the same, except that one uses ordinary bindings, and the other uses
@Native
style bindings. When both tests are run in the same suite, occasionally they will both fail. It's always the case that both fail or both pass.The flake appears to be in the build, not the test. If I change the workflow to build once and run the tests 10 times (and count the failures instead of stopping on failure), then it's always the case that there are either 0 or 10 failures: https://github.com/dart-lang/native/actions/runs/11471378290/job/31980751070?pr=1674
I hit a bit of a wall at this point, because I'm not sure how to get the bad build artifacts from github. So I've just changed these two tests to share the same native code. They still have their own ffigen bindings, but the underlying so file only has one copy of the global variables. Just have to make sure to reset the test state after each test, so they don't interfere with each other.
This seems to have fixed the flake, because there's no longer a conflict between the tests native artifacts. To verify the fix I changed the workflow to run the build/test 10 times, and there were no flakes: https://github.com/dart-lang/native/actions/runs/12386195112/job/34573726773Still flaky.