Use Logger.detached for test loggers
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been looking for this forever! ❤️ (Apparently that API was too hard for me to find! 🤓 ) |
HosseinYousefi
added a commit
that referenced
this pull request
Nov 16, 2023
Closes #132. ASM backend, parses classes, fields and method signatures from the metadata to add generic type information to other-wise type-erased generics.
HosseinYousefi
added a commit
that referenced
this pull request
Nov 16, 2023
Closes #132. ASM backend, parses classes, fields and method signatures from the metadata to add generic type information to other-wise type-erased generics.
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary
Loggerconstructor returns the same instance when given the same string. This meant that all tests effectively used the same instance, breaking the separation of log messages printed in case of a test failure.By using
Logger.detachedevery test actually gets its own logger.Also, a drive by change in
compiler_resolver_test.dartto correct what looks like a typo.