[native_assets_cli] Clarify meaning of targetAndroidNdkApi in docs
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
approved these changes
Oct 4, 2023
| @@ -68,6 +68,11 @@ class BuildConfig { | |||
|
|
|||
| /// When compiling for Android, the API version to target. | |||
| /// | |||
| /// This property is not to be confused with | |||
There was a problem hiding this comment.
Maybe invert the sentence, so that we have what it is first. That is more important. Maybe even leave the what it is not out?
Something along the lines of:
/// When compiling for Android, the minimum Android SDK API version to that the
/// compiled code will be compatible with.
///
/// Required when [targetOs] equals [OS.android].
///
/// Not available in [dryRun].
///
/// For more information about the Android API version, refer to
/// [`minSdkVersion`](https://developer.android.com/ndk/guides/sdk-versions#minsdkversion)
/// in the Android documentation.
int? get targetAndroidNdkApi {There was a problem hiding this comment.
Yes, that's much better. 😄
|
auto label is removed for dart-lang/native/151, due to This PR has not met approval requirements for merging. You are not a member of dart-team and need 1 more review(s) in order to merge this PR.
|
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.