Skip to content

Commit

Permalink
Fix tests (#1052)
Browse files Browse the repository at this point in the history
  • Loading branch information
dcharkes authored Mar 22, 2024
1 parent 335ea7c commit c141234
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 4 deletions.
4 changes: 4 additions & 0 deletions pkgs/native_assets_builder/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.1

- Fix test.

## 0.6.0

- **Breaking change** Completely rewritten API in `native_assets_cli`.
Expand Down
2 changes: 1 addition & 1 deletion pkgs/native_assets_builder/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: native_assets_builder
description: >-
This package is the backend that invokes `build.dart` hooks.
version: 0.6.0
version: 0.6.1
repository: https://github.com/dart-lang/native/tree/main/pkgs/native_assets_builder

environment:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ void main() async {
expect(dryRunAsset.id, buildAsset.id);
// The build runner expands NativeCodeAssets to all architectures.
expect(buildAsset.file, isNotNull);
expect(dryRunAsset.file, isNull);
if (dryRunAsset is NativeCodeAssetImpl &&
buildAsset is NativeCodeAssetImpl) {
expect(dryRunAsset.architecture, isNotNull);
Expand Down
4 changes: 4 additions & 0 deletions pkgs/native_assets_cli/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.2

- Fix test.

## 0.5.1

- Update documentation about providing `NativeCodeAsset.file` in dry runs.
Expand Down
2 changes: 1 addition & 1 deletion pkgs/native_assets_cli/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: >-
native assets CLI.
# Note: Bump BuildConfig.version and BuildOutput.version on breaking changes!
version: 0.5.1
version: 0.5.2
repository: https://github.com/dart-lang/native/tree/main/pkgs/native_assets_cli

topics:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ void main() async {
final dependencies = buildOutput.dependencies;
if (dryRun) {
expect(assets.length, greaterThanOrEqualTo(1));
expect(assets.first.file, isNull);
expect(dependencies, <Uri>[]);
} else {
expect(assets.length, 1);
Expand Down

0 comments on commit c141234

Please sign in to comment.