address comments

dart-lang · Feb 28, 2024 · a1a3554 · a1a3554
1 parent 653dd16
commit a1a3554
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/pkgs/native_assets_cli/example/local_asset/build.dart b/pkgs/native_assets_cli/example/local_asset/build.dart
@@ -32,6 +32,7 @@ void main(List<String> args) async {
     }
 
     output.addAsset(
+      // TODO: Change to DataAsset once the Dart/Flutter SDK can consume it.
       CCodeAsset(
         id: 'library:$packageName/asset.txt',
         file: assetPath,

diff --git a/pkgs/native_assets_cli/lib/native_assets_cli.dart b/pkgs/native_assets_cli/lib/native_assets_cli.dart
@@ -23,4 +23,3 @@ export 'src/api/ios_sdk.dart' show IOSSdk;
 export 'src/api/link_mode.dart' show LinkMode;
 export 'src/api/link_mode_preference.dart' show LinkModePreference;
 export 'src/api/os.dart' show OS;
-// export 'src/api/target.dart' show Target;
diff --git a/pkgs/native_assets_cli/lib/src/api/build.dart b/pkgs/native_assets_cli/lib/src/api/build.dart
@@ -68,6 +68,7 @@ import 'build_output.dart';
 ///     }
 ///
 ///     output.addAsset(
+///       // TODO: Change to DataAsset once the Dart/Flutter SDK can consume it.
 ///       CCodeAsset(
 ///         id: 'library:$packageName/asset.txt',
 ///         file: assetPath,

diff --git a/pkgs/native_assets_cli/lib/src/api/build_config.dart b/pkgs/native_assets_cli/lib/src/api/build_config.dart
@@ -90,7 +90,8 @@ abstract final class BuildConfig {
   /// Not available during a [dryRun].
   CCompilerConfig get cCompiler;
 
-  /// Whether the current run is a "dry run".
+  /// Indicates whether a run should build (wet run) or report potential assets
+  /// (dry run).
   ///
   /// If so, the build won't actually be run, but will report the native assets
   /// which would have been produced.