Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
dcharkes committed Dec 4, 2024
1 parent 3113f5e commit 4814ef9
Showing 1 changed file with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ class DependenciesHashFile {
void _reset() => _hashes = FileSystemHashes();

/// Populate the hashes and persist file with entries from
/// [fileSystemEntities].
/// [fileSystemEntities] and [environment].
///
/// If [fileSystemValidBeforeLastModified] is provided, any entities that were
/// modified after [fileSystemValidBeforeLastModified] will get a dummy hash
/// so that they will show up as outdated. If any such entity exists, its uri
/// will be returned.
/// Any file system entities that were modified after
/// [fileSystemValidBeforeLastModified] will get a dummy hash so that they
/// will show up as outdated. If any such entity exists, its uri will be
/// returned.
Future<Uri?> hashDependencies(
List<Uri> fileSystemEntities,
DateTime fileSystemValidBeforeLastModified,
Expand Down Expand Up @@ -135,8 +135,9 @@ class DependenciesHashFile {
return _hashNotExists;
}
final children = directory.listSync(followLinks: true, recursive: false);
final childrenNames = children.map((e) => _pathBaseName(e.path)).join(';');
return _md5int64(utf8.encode(childrenNames));
final childrenNames = children.map((e) => _pathBaseName(e.path)).toList()
..sort();
return _md5int64(utf8.encode(childrenNames.join(';')));
}

int _hashEnvironmentValue(String? value) {
Expand Down

0 comments on commit 4814ef9

Please sign in to comment.