Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a simple WebSocket interface #1128
Create a simple WebSocket interface #1128
Changes from 7 commits
e6be78b
41a06c3
5630eef
fb5e910
4c2db09
0bfacfa
34eadaa
ee8327f
896c866
6c43b95
b7571d0
5a03e39
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Stream and its relationship with the
sendText
/sendBytes
/close
methods is my biggest concern with this API.As documented now,
sendText
, etc. throw if the WebSocket is closed. But theClosedReceived
event is delivered asynchronously so you can't rely on it being delivered in time to prevent those calls. For example:Some alternatives:
sendText
/sendBytes
after the WebSocket is closed - this is what JavaScript doesSyncStreamController
(will that work?)Stream
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think even if we synchronously surface a
ClosedReceived
there is still the possibility of asendText
failing to write because of a closed socket, though it may be significantly less less likely.I would probably start with throwing, and we can consider an option to silently discard if that has a clear use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan was for
sendText
/sendBytes
to not throw in that case. Any other behavior would be difficult on the web, which only allowssend
to throw if the connection isn't established.I have a conformance test to verify that behavior (the tests are still very rough at this point).
I've updated the docs to make a note of that.
SGTM!