Skip to content

Commit

Permalink
Fix incorrect documentation that used the old isOwned name
Browse files Browse the repository at this point in the history
  • Loading branch information
brianquinlan committed Feb 22, 2024
1 parent 6873731 commit d8dfe29
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions pkgs/cronet_http/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 1.1.2-wip

* Fix a bug in the documentation where `isOwned` is used rather than
`closeEngine`.

## 1.1.1

* Make it possible to construct `CronetClient` with custom a `CronetEngine`
Expand Down
2 changes: 1 addition & 1 deletion pkgs/cronet_http/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void main() async {
cacheMode: CacheMode.memory,
cacheMaxSize: 2 * 1024 * 1024,
userAgent: 'Book Agent');
httpClient = CronetClient.fromCronetEngine(engine, isOwned: true);
httpClient = CronetClient.fromCronetEngine(engine, closeEngine: true);
} else {
httpClient = IOClient(HttpClient()..userAgent = 'Book Agent');
}
Expand Down
2 changes: 1 addition & 1 deletion pkgs/cronet_http/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: cronet_http
version: 1.1.1
version: 1.1.2-wip
description: >-
An Android Flutter plugin that provides access to the Cronet HTTP client.
repository: https://github.com/dart-lang/http/tree/master/pkgs/cronet_http
Expand Down

0 comments on commit d8dfe29

Please sign in to comment.