Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for LDMS CI Workflow #981

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Snell1224
Copy link
Contributor

@Snell1224 Snell1224 commented Mar 21, 2024

@shanedsnyder Turns out this was a known issue that has since been fixed. The ldmsd command was modified to run as a background process when executed so a & needed to be added at the end of this command.

Also, I removed a line of workaround code as it's no longer needed. :)

@github-actions github-actions bot added the CI continuous integration label Mar 21, 2024
@Snell1224 Snell1224 changed the title Fix for LDMS CI Github Test Fix for LDMS CI Workflow Mar 21, 2024
@shanedsnyder
Copy link
Contributor

Awesome, thanks for the quick fix @Snell1224 !

@shanedsnyder shanedsnyder merged commit 6727ab4 into darshan-hpc:main Mar 25, 2024
19 checks passed
@Snell1224 Snell1224 deleted the darshan-ldms-test-patch branch August 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants