Fake entities & minor changes #324

m9w · 2023-10-22T15:06:50Z

It allow customize behavior of collector module & pathfinder without overriding methods these modules. Was added handling of loading raw bytecode. Also was suppressed showing instructions windows if bot running.

This changes required API changes darkbot-reloaded/DarkBotAPI#91

Pablete1234

Generally looking good, just a few tweaks and i'd like to see the semantics of current FakeNpc be brought close together to the other fakes.

Ontop of that, while this is a great API to have, i think the bot itself should be keeping box/mine fakes without needing a behavior/module to do it.

Pablete1234 · 2023-10-29T19:26:02Z

.../com/github/manolo8/darkbot/extensions/features/decorators/InstructionProviderDecorator.java

+        if (obj instanceof Module && !(obj instanceof TemporalModule)
+                && !HeroManager.instance.main.isRunning()
+        ) showInstructions(obj, fd.getName());


I think the pop-up should still appear if the bot is running, but what should change the behavior is as a result of what the change is. If the user changed module i think it's good that they get the pop-up, but i agree if it's an automatic change it shouldn't be shown.
I'm not exactly sure how to properly detect if it was automatic or not, since plugins can be the ones changing the config themselves.

Was added API method for changing config and this call suppressing showing instructions. Also was added default true setting property for suppress showing instructions in all cases.

implement via checking config value

src/main/java/com/github/manolo8/darkbot/core/utils/EntityList.java

src/main/java/com/github/manolo8/darkbot/extensions/plugins/PluginClassLoader.java

src/main/java/eu/darkbot/api/game/entities/FakeEntity.java

m9w · 2023-12-10T15:13:41Z

CAETest.java.txt
module for testing cross-applications events

Pablete1234 · 2023-12-10T23:11:14Z

Please rebase the changes instead of merging, it makes reviewing much harder as all the changes already in the bot since the start of the PR now appear as changes, so its hard to tell what's new and what's not

m9w · 2023-12-11T01:12:39Z

@Pablete1234 changes was rebased, chery-picked, squashed and force pushed.

src/main/java/com/github/manolo8/darkbot/config/ConfigHandler.java

src/main/java/com/github/manolo8/darkbot/config/tree/handlers/DropdownHandler.java

Pablete1234 · 2023-12-11T05:55:22Z

src/main/java/com/github/manolo8/darkbot/core/entities/Box.java

+        private boolean isRemoveWhenAttemptSelect;
+
+        public FakeBox(String boxName, Location loc, long removeDistance, long keepAlive, boolean isRemoveWhenAttemptSelect) {
+            super(Integer.MIN_VALUE);


should probably use different IDs for these, could probably just hold a global fake entity id counter and keep on using extremely low numbers (counting up from min value)

what about random id? super(ThreadLocalRandom.current().nextInt(Integer.MIN_VALUE, -1000));
but I found where it can be used and not sure that it's matter

lets not use randomly generated value here, a defined value or add boolean check to tag them as a "fake" to show the entity is as fake

lets not use randomly generated value here, a defined value or add boolean check to tag them as a "fake" to show the entity is as fake

it's random negative values. For detecting fake can use https://github.com/darkbot-reloaded/DarkBotAPI/pull/91/files#diff-21bb577e67916994b49cca980705fdb72d7f47329f09bac1596e907da599c906R12

So there's two issues here: the game itself already uses negative ids for some stuff, starts with -1, then -2, etc, and it likely will reach -1000 if you run the bot for long enough.

Secondly, with random values it's possible to end with a collision, and i'd want to avoid that.

I don't see the issue in simply having private static int CURR_ID = Integer.MIN_VALUE; and assigning id as super(CURR_ID++), which should generate unique, sequantial, negative ids for everything.

And yeah, as to what anjesh mentioned, the ID is not a way to determine if they're fake entities, check via instanceOf

if use private static int CURR_ID = Integer.MIN_VALUE; and super(CURR_ID++) than we have 2 147 483 648 negative values so when we create more entities then IDs will be positive. I think it not good thing.

P.S. I made it like it wrote in FakeNPC class

creating over 2 bilions of entities seems unreal for me, even with runtime over a year
year have over 30 milions of seconds, so you have to create ~70 entities every second to fill it up in a year

Sorry i actually meant CURR_ID-- not ++.

The thing about FakeNPC is it's guaranteed to only exist once, its used as a singleton

implemented

src/main/java/com/github/manolo8/darkbot/core/manager/CrossApplicationEventManager.java

.../com/github/manolo8/darkbot/extensions/features/decorators/InstructionProviderDecorator.java

Pablete1234 · 2024-03-06T17:41:00Z

.../com/github/manolo8/darkbot/extensions/features/decorators/InstructionProviderDecorator.java

+                && ConfigEntity.INSTANCE.getConfig().BOT_SETTINGS.OTHER.SHOW_INSTRUCTIONS
+        ) showInstructions(obj, fd.getName());


Suggested change

&& ConfigEntity.INSTANCE.getConfig().BOT_SETTINGS.OTHER.SHOW_INSTRUCTIONS

) showInstructions(obj, fd.getName());

&& ConfigEntity.INSTANCE.getConfig().BOT_SETTINGS.OTHER.SHOW_INSTRUCTIONS)

showInstructions(obj, fd.getName());

minor formatting change

src/main/java/com/github/manolo8/darkbot/extensions/plugins/PluginClassLoader.java

Pablete1234 · 2024-03-06T17:43:22Z

src/main/java/com/github/manolo8/darkbot/core/utils/EntityList.java

@@ -128,6 +129,24 @@ private void onEntityCreate(Entity entity) {
        this.eventBroker.sendEvent(new EntityCreateEvent(entity));
    }

+    public FakeEntity.FakeMine createFakeMine(int typeId, eu.darkbot.api.game.other.Location  loc, long removeDistance, long keepAlive) {


Suggested change

public FakeEntity.FakeMine createFakeMine(int typeId, eu.darkbot.api.game.other.Location loc, long removeDistance, long keepAlive) {

public FakeEntity.FakeMine createFakeMine(int typeId, eu.darkbot.api.game.other.Location loc, long removeDistance, long keepAlive) {

minor formatting change

Pablete1234 · 2024-03-06T17:43:38Z

src/main/java/com/github/manolo8/darkbot/core/manager/GuiManager.java

@@ -141,6 +141,7 @@ public GuiManager(Main main, PluginAPI pluginAPI, RepairManager repairManager) {
        this.assembly = register("assembly");

        register("ggBuilder", GateSpinnerGui.class);
+        register("refinement_count");


does this not belong to a diff PR?

Pablete1234 · 2024-03-06T17:45:24Z

src/main/java/com/github/manolo8/darkbot/core/entities/Box.java

@@ -135,4 +141,61 @@ public Beacon(int id, long address) {
            super(id, address);
        }
    }
+
+    public static class FakeBox extends Box implements eu.darkbot.api.game.entities.FakeEntity.FakeBox {
+        private static int CURR_ID = Integer.MIN_VALUE;


needs to be shared by all fake entities, to avoid duplicate ids. Just have this sit in some util where you can EntityUtil.allocateFakeId() and it returns CURR_ID++ or similar

Pablete1234 · 2024-03-06T17:45:59Z

src/main/java/com/github/manolo8/darkbot/Bot.java

+            try {
+                Popups.setDefaultIcon(MainGui.ICON);
+            } catch (Exception e) {
+                e.printStackTrace();
+            }


i wonder, what's the motive behind this change? is it throwing an exception under some systems? if so, which exception?

Pablete1234 · 2024-10-19T11:20:11Z

Given the commit was abandoned i've re-coded it, implemented the updated fake entities api, and also introduced the option for instructions.
If you feel other important changes were left out feel free to open separate PRs for each of the feature changes you want us to consider, avoid making mega-prs which merge different features.

m9w changed the title ~~Fake enitites + loader~~ Fake entities + loader Oct 22, 2023

Pablete1234 requested changes Oct 29, 2023

View reviewed changes

m9w changed the title ~~Fake entities + loader~~ Fake entities & classloader & config API & cross-applications events Dec 10, 2023

m9w force-pushed the customization branch from 38a7663 to 2deab68 Compare December 11, 2023 01:09

Pablete1234 reviewed Dec 11, 2023

View reviewed changes

src/main/java/com/github/manolo8/darkbot/config/ConfigHandler.java Outdated Show resolved Hide resolved

Pablete1234 reviewed Dec 11, 2023

View reviewed changes

src/main/java/com/github/manolo8/darkbot/config/tree/handlers/DropdownHandler.java Outdated Show resolved Hide resolved

Pablete1234 reviewed Dec 11, 2023

View reviewed changes

src/main/java/com/github/manolo8/darkbot/core/manager/CrossApplicationEventManager.java Outdated Show resolved Hide resolved

Pablete1234 reviewed Dec 11, 2023

View reviewed changes

.../com/github/manolo8/darkbot/extensions/features/decorators/InstructionProviderDecorator.java Outdated Show resolved Hide resolved

Fake entities API & micro patches

641065f

m9w force-pushed the customization branch from 5463e25 to 641065f Compare January 18, 2024 13:52

remove rows from strings_en.properties

75ab8de

m9w changed the title ~~Fake entities & classloader & config API & cross-applications events~~ Fake entities & classloader & config API Jan 18, 2024

m9w changed the title ~~Fake entities & classloader & config API~~ Fake entities & minor changes Jan 18, 2024

Pablete1234 requested changes Mar 6, 2024

View reviewed changes

Pablete1234 closed this Oct 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fake entities & minor changes #324

Fake entities & minor changes #324

m9w commented Oct 22, 2023 •

edited

Loading

Pablete1234 left a comment

Pablete1234 Oct 29, 2023

m9w Dec 10, 2023

m9w Dec 15, 2023

m9w commented Dec 10, 2023

Pablete1234 commented Dec 10, 2023

m9w commented Dec 11, 2023

Pablete1234 Dec 11, 2023

m9w Dec 11, 2023

anjeshshrestha Dec 11, 2023

m9w Dec 11, 2023

Pablete1234 Dec 12, 2023

m9w Dec 12, 2023

Punikekk Dec 12, 2023

Pablete1234 Dec 12, 2023 •

edited

Loading

m9w Dec 15, 2023

Pablete1234 Mar 6, 2024

Pablete1234 Mar 6, 2024

Pablete1234 Mar 6, 2024

Pablete1234 Mar 6, 2024

Pablete1234 Mar 6, 2024

Pablete1234 commented Oct 19, 2024

		&& ConfigEntity.INSTANCE.getConfig().BOT_SETTINGS.OTHER.SHOW_INSTRUCTIONS
		) showInstructions(obj, fd.getName());

	public FakeEntity.FakeMine createFakeMine(int typeId, eu.darkbot.api.game.other.Location loc, long removeDistance, long keepAlive) {
	public FakeEntity.FakeMine createFakeMine(int typeId, eu.darkbot.api.game.other.Location loc, long removeDistance, long keepAlive) {

Fake entities & minor changes #324

Fake entities & minor changes #324

Conversation

m9w commented Oct 22, 2023 • edited Loading

Pablete1234 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m9w commented Dec 10, 2023

Pablete1234 commented Dec 10, 2023

m9w commented Dec 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pablete1234 Dec 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pablete1234 commented Oct 19, 2024

m9w commented Oct 22, 2023 •

edited

Loading

Pablete1234 Dec 12, 2023 •

edited

Loading