add agatus proxy #323
Closed
add agatus proxy #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
reviewed
Oct 19, 2023
src/main/java/com/github/manolo8/darkbot/core/manager/FacadeManager.java
Outdated
Show resolved
Hide resolved
Pablete1234
reviewed
Nov 25, 2023
|
|
||
| import eu.darkbot.api.managers.AgatusAPI; | ||
|
|
||
| public class AgatusEventProxy extends DefaultNpcEventProxy implements AgatusAPI { |
There was a problem hiding this comment.
It seems like a pretty bad pattern to be extending a class without any changes at all. Is the issue here simply that this should be a higher-level api?
Instead of a DefaultNpcEventAPI maybe it should be a NpcEventAPI which returns a list or a map of NpcEvent objects.
interface NpcEventAPI {
NpcEvent getEvent(EventType type);
enum EventType {
GENERIC, AGATUS, ...;
}
}The implementation can use the Agatus proxy and the generic npc event proxy, and in the plugin-side you can:
NpcEventAPI.getEvent(EventType.AGATUS) to get an NpcEvent with the info related to agatus.
|
Added in b902589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.