This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
forked from JoshOrndorff/substrate-node-template
-
Notifications
You must be signed in to change notification settings - Fork 23
Add Multisig and Proxy pallets #157
Open
F3Joule
wants to merge
5
commits into
dappforce:master
Choose a base branch
from
F3Joule:f3-add-pallets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F3Joule
commented
Nov 12, 2021
F3Joule
commented
Nov 15, 2021
@@ -7,7 +7,7 @@ pub mod currency { | |||
pub const MILLICENTS: Balance = CENTS / 1_000; // 1_000_000 | |||
|
|||
pub const fn deposit(items: u32, bytes: u32) -> Balance { | |||
items as Balance * 15 * CENTS + (bytes as Balance) * 6 * CENTS | |||
items as Balance * 2_000 * CENTS + (bytes as Balance) * 100 * MILLICENTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F3Joule
commented
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
You can compare pallets parameters with:
https://github.com/paritytech/substrate/blob/polkadot-v0.9.10/bin/node/runtime/src/lib.rs
F3Joule
force-pushed
the
f3-add-pallets
branch
from
November 24, 2021 14:44
d717f16
to
4722a72
Compare
F3Joule
added
enhancement
New feature or request
and removed
crowdloan
Required for crowdloan
labels
Nov 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
spec_version
to 17