Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add post follows pallet to the runtime #251

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Conversation

F3Joule
Copy link
Member

@F3Joule F3Joule commented Jan 11, 2024

Release Checklist

  • Verify spec_version has been incremented since the last release.
  • Verify pallet and extrinsic ordering has stayed the same. Bump transaction_version if not.
  • Verify new extrinsics have been correctly whitelisted/blacklisted for BaseCallFilter
  • There are benchmarks for newly created extrinsics.
  • Verify weights have been updated for any modified runtime logic.
  • There are tests for newly created logic.
  • All the tests pass.
  • Ensure migrations run correctly

@F3Joule F3Joule self-assigned this Jan 11, 2024
@F3Joule F3Joule added the feature-release A new feature PR ready to release label Jan 11, 2024
@F3Joule F3Joule changed the title Add post follows pallet to the runtime feat!: Add post follows pallet to the runtime Jan 11, 2024
@F3Joule
Copy link
Member Author

F3Joule commented Jan 11, 2024

Metadata comparison (extrinsics ordering check) results:

Metadata comparison:
Date: Thu 11 Jan 2024 15:07:50 EET
Reference: wss://para.subsocial.network
Target version: subsocial-collator 0.2.1-104d3248463
Chain: dev
----------------------------------------------------------------------
              [Spec] name: subsocial-parachain
                     spec_version: 36 -> 37
                     transaction_version: 7 -> 8
          [Metadata] version: 14
           [Modules] num: 37 -> 38
                     [+] modules: PostFollows
                          [System] idx: 0 (calls: 8, storage: 17)
                 [ParachainSystem] idx: 1 (calls: 4, storage: 22)
                       [Timestamp] idx: 3 (calls: 1, storage: 3)
                        [Balances] idx: 10 (calls: 6, storage: 6)
                        [Treasury] idx: 12 (calls: 5, storage: 5)
               [CollatorSelection] idx: 21 (calls: 5, storage: 6)
                         [Session] idx: 22 (calls: 2, storage: 8)
                         [Vesting] idx: 26 (calls: 5, storage: 3)
                           [Proxy] idx: 27 (calls: 10, storage: 3)
                        [Multisig] idx: 29 (calls: 4, storage: 2)
                       [XcmpQueue] idx: 30 (calls: 9, storage: 11)
                     [PolkadotXcm] idx: 31 (calls: 10, storage: 12)
                        [DmpQueue] idx: 33 (calls: 1, storage: 6)
                         [Domains] idx: 60 (calls: 9, storage: 8)
                          [Energy] idx: 61 (calls: 2, storage: 4)
                       [FreeProxy] idx: 62 (calls: 1, storage: 2)
                  [CreatorStaking] idx: 63 (calls: 14, storage: 13)
                    [EvmAddresses] idx: 64 (calls: 2, storage: 3)
             [ResourceDiscussions] idx: 65 (calls: 2, storage: 2)
                           [Roles] idx: 71 (calls: 8, storage: 6)
                  [AccountFollows] idx: 72 (calls: 3, storage: 4)
                        [Profiles] idx: 73 (calls: 3, storage: 2)
                    [SpaceFollows] idx: 74 (calls: 3, storage: 4)
                  [SpaceOwnership] idx: 75 (calls: 3, storage: 2)
                          [Spaces] idx: 76 (calls: 4, storage: 4)
                           [Posts] idx: 77 -> 78 (calls: 6, storage: 6)
                       [Reactions] idx: 78 -> 79 (calls: 6, storage: 5)
                            [Sudo] idx: 255 (calls: 4, storage: 2)

------------------------------ SUMMARY ------------------------------- 
⚠️ This filter is here to help spotting changes that should be reviewed carefully. 
⚠️ It catches only index changes, deletions and value decreases. 
## Deletions
 n/a 
## Index changes
 38: [Posts] idx: 77 -> 78 (calls: 6, storage: 6)
 39: [Reactions] idx: 78 -> 79 (calls: 6, storage: 5)
## Decreases
 n/a 

@F3Joule
Copy link
Member Author

F3Joule commented Jan 11, 2024

Try runtime results:

initialized state externalities with storage root 0xe886761dd5559e01d5a16dd7f89b35088a6ed11f98b887d2c440b06ba8ff4100 and state_version V0
original spec: RuntimeString::Owned("subsocial-parachain")-36, code hash: ccdd0afea1462160b9dad3377bcceab57639268d7ee49b4dbb502efe99b5812f
new spec: RuntimeString::Owned("subsocial-parachain")-37, code hash: ff4b77151c19f33deb4e882c7f43bdd14678191fc58afbf60bedbd0d309d445c
⚠️ ParachainSystem declares internal migrations (which *might* execute). On-chain `StorageVersion(2)` vs current storage version `StorageVersion(2)`
⚠️ XcmpQueue declares internal migrations (which *might* execute). On-chain `StorageVersion(3)` vs current storage version `StorageVersion(2)`
⚠️ PolkadotXcm declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(1)`
⚠️ DmpQueue declares internal migrations (which *might* execute). On-chain `StorageVersion(2)` vs current storage version `StorageVersion(1)`
TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = (200000000 ps, 0 byte), total weight = (500000000000 ps, 5242880 byte) (0.04 %, 0.00 %).

@F3Joule F3Joule merged commit 22d6343 into main Jan 11, 2024
@F3Joule F3Joule deleted the f3/add-post-follows branch January 11, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-release A new feature PR ready to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants