Add tests for creator-staking pallet #234

F3Joule · 2023-10-04T08:47:17Z

No description provided.

pallets/creator-staking/src/tests/testing_utils.rs

pallets/creator-staking/src/tests/tests_lib.rs

pallets/creator-staking/src/tests/tests.rs

olehmell · 2023-10-10T10:21:44Z

pallets/creator-staking/src/tests/tests.rs

+    })
+}
+
+// FIXME: how to be here?


So, are you going to fix?

pallets/creator-staking/src/tests/tests.rs

pallets/creator-staking/src/lib.rs

pallets/creator-staking/src/tests/tests.rs

- Rename to RewardDistributionConfig - Rename impl fn `is_consistent` to `is_sum_equal_to_one` Co-Authored-By: siman <[email protected]>

Co-Authored-By: siman <[email protected]> Co-Authored-By: olehmell <[email protected]>

- Fixed accross the creator staking pallet

* Rename staker to backer in creator staking pallet - Fix all ledger occurrences - Introduce CreatorId type alias (for SpaceId) for consistency purposes * Apply suggestions from docs review Co-authored-by: Yung Beef 4.2 <[email protected]> * Apply more suggestions from docs review Co-authored-by: Yung Beef 4.2 <[email protected]> * Remove unnecessary doc * Update update_backer_info arguments names * Rename UnlockingChunk > UnbondingChunk * Rename impl unstake to decrease_stake * Rename GeneralBackerInfo to BackerStakesByCreator - Consistently renamed backer_info to backer_stakes * Fix typo in creator staking pallet docs * Rename total to total_staked in CreatorStakeInfo * Rename all unlocking to unbonding in creator staking pallet * Add tests for creator-staking pallet (#234) * Add tests for creator staking * Add inflation tests * Add new event on changing distribution config * Update RewardsDistributionConfig struct - Rename to RewardDistributionConfig - Rename impl fn `is_consistent` to `is_sum_equal_to_one` Co-Authored-By: siman <[email protected]> * Apply suggestions from code review Co-Authored-By: siman <[email protected]> Co-Authored-By: olehmell <[email protected]> * Rename unregister_era to unregistration_era * Fix doc in tests * FIx visibility modificators in creator staking pallet * Fix unlocking_chunks and backer_info namings - Fixed accross the creator staking pallet --------- Co-authored-by: siman <[email protected]> Co-authored-by: olehmell <[email protected]> * Apply fixes after final code review (#236) * Refactor ensure_creator_active_in_era * Rename `should_restake` to `can_restake` * Rename a few events in creator staking pallet - Fix on_initialize weights * Fix namings * Rename ensure fn in creator staking pallet Co-Authored-By: siman <siman@ [email protected]> * Fix error name Co-Authored-By: siman <siman@ [email protected]> * Fix namings in RPCs functions * Add creator_id to StakeWithdrawnFromInactiveCreator event * Add transfer space ownership restrictions For now it's not possible to transfer space ownership if space is registered as a creator * Refactor transfer space ownership restriction * Update doc for CreatorStakingProvider * Introduce ensure_not_active_creator in space-ownership pallet - Fix impl for empty tuple to make tests pass. --------- Co-authored-by: siman <siman@ [email protected]> * Add more RPCs to creator staking pallet (#235) * Fix creator staking RPCs * Fix bug in claim function for backers * Add more RPCs to creator staking pallet There are 2 RPCs: the first one to get estimated rewards, the second one to get claimable eras. * Apply suggestions from code review - Fix code formating --------- Co-authored-by: Yung Beef 4.2 <[email protected]> Co-authored-by: siman <[email protected]> Co-authored-by: olehmell <[email protected]>

* Improve docs and grammar in creator staking pallet (#233) * Add tests for creator-staking pallet (#234) * Apply fixes after final code review (#236) * Add more RPCs to creator staking pallet (#235) --------- Co-authored-by: siman <[email protected]> Co-authored-by: Alex Siman <[email protected]> Co-authored-by: Yung Beef 4.2 <[email protected]> Co-authored-by: olehmell <[email protected]>

* Add custom RPC to creator staking pallet * Add RPC functions' logic to a runtime - Add creator-staking RPC to the node - Update Cargo.lock * Add claims count RPC * Apply grammar fixes from code review Co-authored-by: Oleh Mell <[email protected]> * Apply suggestions after creator staking code review (#232) * Improve docs and grammar in creator staking pallet (#233) * Add tests for creator-staking pallet (#234) * Apply fixes after final code review (#236) * Add more RPCs to creator staking pallet (#235) --------- Co-authored-by: Oleh Mell <[email protected]> Co-authored-by: siman <[email protected]> Co-authored-by: Alex Siman <[email protected]> Co-authored-by: Yung Beef 4.2 <[email protected]> Co-authored-by: olehmell <[email protected]>

* Add custom RPCs to creator staking (#231) * Apply suggestions after creator staking code review (#232) * Improve docs and grammar in creator staking pallet (#233) * Add tests for creator-staking pallet (#234) * Apply fixes after final code review (#236) * Add more RPCs to creator staking pallet (#235) * Bump crates version to 0.1.10 * Update spec_version to 29 * Remove redundant migration from runtime --------- Co-authored-by: olehmell <[email protected]> Co-authored-by: Alex Siman <[email protected]> Co-authored-by: Oleh Mell <[email protected]> Co-authored-by: siman <[email protected]> Co-authored-by: Yung Beef 4.2 <[email protected]>

F3Joule self-assigned this Oct 4, 2023

F3Joule requested a review from olehmell October 4, 2023 08:47

F3Joule changed the title ~~Add compilable tests for creator-staking pallet~~ Add tests for creator-staking pallet Oct 6, 2023

F3Joule force-pushed the f3/cs-tests-and-benches branch from fa34e6d to 79e2b65 Compare October 6, 2023 10:25

olehmell suggested changes Oct 9, 2023

View reviewed changes