Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #33 - Building with idf.py fails #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

project-x51
Copy link

Hi Danjulio,

I hope this helps.

Robin

@danjulio
Copy link
Owner

danjulio commented Aug 8, 2022

Hey Robin,

I'm definitely interested in moving to 4.4.1 and it seems you did all the hard work. So thank you for that. As you might have noticed I just released a big change (version 3.0) so I'll have to take a look how best to integrate. I hope to get to that later this week.

Cheers, Dan

@project-x51
Copy link
Author

Hi Dan,

The changes were made to the version 3.0 code base so it should be just a matter of merging them with the master branch.

There are a number of warnings for depreciated calls that would ideally be resolved to make the code 100% V4.41.

Robin

@danjulio
Copy link
Owner

danjulio commented Aug 9, 2022

Hey Robin,

I installed IDF 4.4.2 (current "stable") and merged your changes in a local repository, compiled and successfully loaded a camera! I see the deprecated calls and agree, they need to be fixed (there are also some warnings about assignments in different structure types now). I also see that the new IDF allocates different amounts of memory which makes me a little nervous (obviously they changed stuff under the hood). So my plan is to fix the deprecated calls, do a lot of testing, include other bug fixes and changes and then commit this new version back as 3.1 with 4.4.2 as the new build environment.

FYI: I had made some changes to the Flash configuration in the sdkconfig (80 MHz QIO accesses) which I don't think you got in the new sdkconfig. Let me know if you'd like to see my sdkconfig.

Again, thank you for the effort and for sharing your changes.

Regards, Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants