sparse: fix alist format by including padding #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@page0egap let me know if this looks good. |
|
In file I review all changes and do not find other errors. For myself, it's able to parse irregular ldpc's alist format file, for example CCSDS(N=128, M=64). I think it solves my problem. |
In #2 it was pointed that the alist format used by ldpc-toolbox is incorrect because it does not include zeros for padding of irregular codes, as required by MacKay's original definition. This fixes the problem in the following way: - The SparseMatrix::from_alist function supports reading both the format with zero padding and the format without zero padding. - The SparseMatrix::write_alist and SparseMatrix::alist functions now include zero padding. There are variants of these functions called write_alist_no_padding and alist_no_padding which omit the zero padding. Additionally, the whitespace at the end of each line generated by write_alist has been removed.
daniestevez
force-pushed
the
fix-alist-format
branch
from
3acfba1
to
c3a9e39
Compare
Good catch! A copy & paste mistake. I've just fixed this and force-pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2 it was pointed that the alist format used by ldpc-toolbox is incorrect because it does not include zeros for padding of irregular codes, as required by MacKay's original definition.
This fixes the problem in the following way:
The SparseMatrix::from_alist function supports reading both the format with zero padding and the format without zero padding.
The SparseMatrix::write_alist and SparseMatrix::alist functions now include zero padding. There are variants of these functions called write_alist_no_padding and alist_no_padding which omit the zero padding.
Additionally, the whitespace at the end of each line generated by write_alist has been removed.