Encode and decode remote XPC messages #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmissmann
force-pushed
the
dm-xpc-codec
branch
from
3cd9dbe
to
1eb9bcf
Compare
danielpaulus
requested changes
Oct 20, 2023
ios/xpc/encoding.go
Outdated
| return err | ||
| } | ||
|
|
||
| var flags uint32 |
There was a problem hiding this comment.
#nitpick
might be bit easier to read this way
flags:=alwaysSetFlag
if len(body) != 0 {
flags |= dataFlag
}
| } | ||
|
|
||
| wrapper := struct { | ||
| magic uint32 |
There was a problem hiding this comment.
you have two structs defined at the top and one inline, I think it would be better to all define them at the top for easier reading.
There was a problem hiding this comment.
I move the anonymous structs to the top as they are used only here for the encoding part (you'll find them in more places here btw 😉 ), the ones at the top are used in multiple places.
ios/xpc/encoding.go
Outdated
| if buf[0] == 0 { | ||
| s := b.String() | ||
| toSkip := calcPadding(len(s) + 1) | ||
| io.CopyN(io.Discard, r, toSkip) |
There was a problem hiding this comment.
_,err := io.CopyN(io.Discard, r, toSkip)
return s, err
ios/xpc/encoding.go
Outdated
| func decodeUint64(r io.Reader) (uint64, error) { | ||
| var i uint64 | ||
| err := binary.Read(r, binary.LittleEndian, &i) | ||
| if err != nil { |
There was a problem hiding this comment.
return i, err
would also work
ios/xpc/encoding.go
Outdated
| t xpcType | ||
| l uint32 | ||
| }{stringType, uint32(len(s) + 1)} | ||
| binary.Write(w, binary.LittleEndian, header) |
dmissmann
force-pushed
the
dm-xpc-codec
branch
from
1eb9bcf
to
c2a043d
Compare
Not all types and flags are implemented yet. It works only with maps and not custom struct types
dmissmann
force-pushed
the
dm-xpc-codec
branch
from
f959069
to
ad57e48
Compare
danielpaulus
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for iOS 17 support. Some new services write RemoteXPC messages over a HTTP2 connection.
The actual work of deciphering those messages was done by somebody else, please check this blog post from Duo.com