Check for non-empty 'Error' string in 'StartSessionResponse' (#515)

* Check for non-empty 'Error' string in 'StartSessionResponse' * Add more context to lockdown session start error Co-authored-by: dmissmann <[email protected]> * Fix imports --------- Co-authored-by: dmissmann <[email protected]>
danielpaulus · Nov 18, 2024 · 1fcc2a1 · 1fcc2a1
1 parent b8669ed
commit 1fcc2a1
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/ios/startsession.go b/ios/startsession.go
@@ -2,6 +2,7 @@ package ios
 
 import (
 	"bytes"
+	"fmt"
 
 	plist "howett.net/plist"
 )
@@ -29,6 +30,7 @@ type StartSessionResponse struct {
 	EnableSessionSSL bool
 	Request          string
 	SessionID        string
+	Error            string
 }
 
 func startSessionResponsefromBytes(plistBytes []byte) StartSessionResponse {
@@ -52,6 +54,9 @@ func (lockDownConn *LockDownConnection) StartSession(pairRecord PairRecord) (Sta
 		return StartSessionResponse{}, err
 	}
 	response := startSessionResponsefromBytes(resp)
+	if response.Error != "" {
+		return StartSessionResponse{}, fmt.Errorf("failed to start new lockdown session: %s", response.Error)
+	}
 	lockDownConn.sessionID = response.SessionID
 	if response.EnableSessionSSL {
 		err = lockDownConn.deviceConnection.EnableSessionSsl(pairRecord)