Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to sort statistics results #78

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

danielemery
Copy link
Owner

Resolves #76

  • Can either sort by number of quizzes descending, or average score descending
    • By default it's number of quizzes completed
  • Took the opportunity to document and test the whole statistics service

@danielemery danielemery self-assigned this Nov 12, 2023
@danielemery danielemery linked an issue Nov 12, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (625c08e) 8.40% compared to head (9c2a3dd) 20.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #78       +/-   ##
==========================================
+ Coverage   8.40%   20.65%   +12.24%     
==========================================
  Files         19       19               
  Lines        452      460        +8     
  Branches      65       70        +5     
==========================================
+ Hits          38       95       +57     
+ Misses       400      353       -47     
+ Partials      14       12        -2     
Files Coverage Δ
src/gql.ts 0.00% <ø> (ø)
src/quiz/quiz.service.ts 48.48% <100.00%> (+20.12%) ⬆️
src/statistics/statistics.service.ts 100.00% <100.00%> (+100.00%) ⬆️
src/user/user.service.ts 0.00% <ø> (ø)
src/statistics/statistics.gql.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielemery danielemery merged commit 9b44d32 into main Nov 12, 2023
2 checks passed
@danielemery danielemery deleted the 76-add-ability-to-sort-statistics-results branch May 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to sort statistics results
2 participants