Support Twilio API key-based authentication #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers existing behavior as well as the api_key/api_secret options being added
Allow callers of the REST API to pass `api_key` and `api_secret` options to use API keys for authenticating to Twilio in lieu of the account sid and auth token: https://www.twilio.com/docs/glossary/what-is-an-api-key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for API key auth as discussed in #124
With this change callers to APIs are able to pass
api_keyandapi_secretoptions to the various REST API calls to use API key-based auth in place of the account token-based auth. This works by following the pattern of the optionalaccount/tokenparams already supported for sub-account auth.I will admit I do not know Twilio's various APIs all that well or the internals of this library all that well. So my manual testing was limited to the
ExTwilio.Message.createfunction which is the only place I happen to need this functionality.When using API keys for auth you still need the account-level SID in your
ExTwilioconfiguration but the account-level auth token can be omitted.Also happy to do some other manual testing or revisit this approach, with a little guidance, if this PR seems way off the mark.