Adding tests for a trigger call for unknown event

daniel-aranda · Apr 10, 2015 · 2e1efa9 · 2e1efa9
1 parent bb2589f
commit 2e1efa9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/core/PHPRocks/EventHandler.php b/core/PHPRocks/EventHandler.php
@@ -33,6 +33,7 @@ public function trigger($event_name, $arguments = [])
             call_user_func_array($event, $arguments);
         }
 
+        return true;
     }
 
     /**

diff --git a/tests/PHPRocks/EventHandlerTest.php b/tests/PHPRocks/EventHandlerTest.php
@@ -129,4 +129,9 @@ public function testRemoveEventHandlerNotFoundEventDueClosure()
 
     }
 
+    public function testTriggerUnknownEvent()
+    {
+        $this->assertNull($this->event_handler->trigger('random_event_this'));
+    }
+
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,6 +33,7 @@ public function trigger($event_name, $arguments = []) @@
                 call_user_func_array($event, $arguments);
             }
+            return true;
         }
         /**
@@ Expand Down @@