Added null escaping

Added failing null character escaping test Fixes geddy#245
danfinlay · Feb 6, 2015 · 47c61d3 · 47c61d3
1 parent 63833b6
commit 47c61d3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/datatypes.js b/lib/datatypes.js
@@ -62,6 +62,7 @@ _escape = function (s, type) {
     // Scrub input for basic SQL injection protection
     case 'sql':
       ret = s.replace(/'/g, "''");
+      ret = ret.replace('\u0000', ' ');
       break;
     // Backslash-esc single quotes for use in M/R JS sourcecode str
     case 'js':

diff --git a/test/integration/adapters/shared.js b/test/integration/adapters/shared.js
@@ -1230,6 +1230,15 @@ tests = {
     });
   });
 }
+
+, 'test escaping null characters': function (next) {
+    var person = model.Person.create({title: 'test \u0000!'});
+    person.save(function (err, data) {
+      if (err) { throw err; }
+      next();
+    });
+  }
+
 };
 
 module.exports = tests;