Temporarily disable manifest file GC in prod

dandi · Nov 21, 2024 · 156daf8 · 156daf8
1 parent b6dc95f
commit 156daf8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/terraform/modules/dandiset_bucket/main.tf b/terraform/modules/dandiset_bucket/main.tf
@@ -344,7 +344,7 @@ resource "aws_s3_bucket_lifecycle_configuration" "expire_noncurrent_manifest_fil
   # Must have bucket versioning enabled first
   depends_on = [aws_s3_bucket_versioning.dandiset_bucket]
 
-  count = var.versioning ? 1 : 0
+  count = var.versioning ? 1 : 0 && var.enable_manifest_file_expiration
 
   bucket = aws_s3_bucket.dandiset_bucket.id
 

diff --git a/terraform/modules/dandiset_bucket/variables.tf b/terraform/modules/dandiset_bucket/variables.tf
@@ -34,3 +34,10 @@ variable "log_bucket_name" {
   type        = string
   description = "The name of the log bucket."
 }
+
+# TODO: remove this after it's ready to be enabled in production
+variable "enable_manifest_file_expiration" {
+  type        = bool
+  description = "Whether or not to enable expiration of manifest files."
+  default     = false
+}
diff --git a/terraform/staging_bucket.tf b/terraform/staging_bucket.tf
@@ -10,6 +10,7 @@ module "staging_dandiset_bucket" {
     aws         = aws
     aws.project = aws
   }
+  enable_manifest_file_expiration = true
 }
 
 module "staging_embargo_bucket" {