Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinionated support for ?thing params #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomsowerby
Copy link
Contributor

Current behaviour encourages

/**
 * @param string $thing
 */
function doStuff(?string $thing) { ... }

I think that it should be:

/**
 * @param string|null $thing
 */
function doStuff(?string $thing) { ... }

When the ? is present, the type is nested, with the parent type being NullableType. We deal with this already on line 156 and extract the name of the child, so we can hook into this further to add the '|null' if we have this parent/child combination.

This one might be a bit opinionated, so happy to discuss more...

Current behaviour encourages

    /**
     * @param string $thing
     */
    function doStuff(?string $thing) { ... }

I think that it should be:

    /**
     * @param string|null $thing
     */
    function doStuff(?string $thing) { ... }

When the ? is present, the type is nested, with the parent type being NullableType. We deal with this already on line 156 and extract the name of the child, so we can hook into this further to add the '|null' if we have this parent/child combination.

This one might be a bit opinionated, so happy to discuss more...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant