WIP proof of concept to add localization using fluent-rs #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyiu
commented
Dec 5, 2024
| let mut errors = vec![]; | ||
| let msg = bundle.get_message("universe-title").expect("Message exists"); | ||
| let pattern = msg.value().expect("Message has a value"); | ||
| let value: &'static mut str = bundle.format_pattern(pattern, None, &mut errors).to_string().leak(); |
There was a problem hiding this comment.
This leak intuitively seems wrong to me, but I couldn't get passed compilation errors without it. title in ColumnOptionData is static and I didn't know how to get the string from the fluent library there in any other way. Looking for feedback here.
There was a problem hiding this comment.
I think we just need to cache the bundle in our app state and fix some of these string lifetimes and we should be good to go. I'll take a pass at it. thanks for getting this started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge. I'm new to Rust, and I'm opening this proof of concept PR to solicit feedback to ensure that I'm doing the right thing before I make changes for real.