-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use user's relay list #346
Draft
ksedgwic
wants to merge
11
commits into
damus-io:master
Choose a base branch
from
ksedgwic:2024-09-user-relay-list
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksedgwic
force-pushed
the
2024-09-user-relay-list
branch
2 times, most recently
from
October 17, 2024 23:03
32df56e
to
20ea787
Compare
ksedgwic
force-pushed
the
2024-09-user-relay-list
branch
4 times, most recently
from
October 18, 2024 03:59
ff6aba8
to
68334b3
Compare
sorry for the delay, looking at this now |
We really shouldn't ever need a Mutex, since our program is single-threaded. So I'm confused why we're restructuring the core application around mutexes. This seems deeply wrong to me. |
Needed for Clippy
- Add dispatcher and task modules - android: use wrapped damus - Set the relay list to exactly the user's list - don't ever clear the relay list entirely, happens when bootstrapping - refactor track_user_relays for clarity - use ndb set_sub_cb to receive sub update notifications
ksedgwic
force-pushed
the
2024-09-user-relay-list
branch
from
October 22, 2024 19:41
88f52d5
to
4162481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dispatching to async task is working and the user's relay list is being found and printed to the log.
The dispatch scheme is designed to be general enough to handle other tasks ... how does it look?
TODO: