Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user's relay list #346

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ksedgwic
Copy link
Contributor

@ksedgwic ksedgwic commented Oct 9, 2024

The dispatching to async task is working and the user's relay list is being found and printed to the log.

The dispatch scheme is designed to be general enough to handle other tasks ... how does it look?

TODO:

  • Certify the approach
  • Add the user's relays
  • Remove relays that aren't in the user's list?
  • Complete lifetime issues (unsubscribe when done)
  • Need to close the removed relay connections
  • Should we have some "fixed" relays in case the user's list is all bad?
  • What happens when the user manually adds a relay?
  • Address race between ingestion and notification
  • Consider converting other things

@ksedgwic ksedgwic force-pushed the 2024-09-user-relay-list branch 2 times, most recently from 32df56e to 20ea787 Compare October 17, 2024 23:03
@ksedgwic ksedgwic force-pushed the 2024-09-user-relay-list branch 4 times, most recently from ff6aba8 to 68334b3 Compare October 18, 2024 03:59
@jb55
Copy link
Contributor

jb55 commented Oct 22, 2024

sorry for the delay, looking at this now

@jb55
Copy link
Contributor

jb55 commented Oct 22, 2024

We really shouldn't ever need a Mutex, since our program is single-threaded. So I'm confused why we're restructuring the core application around mutexes. This seems deeply wrong to me.

- Add dispatcher and task modules
- android: use wrapped damus
- Set the relay list to exactly the user's list
- don't ever clear the relay list entirely, happens when bootstrapping
- refactor track_user_relays for clarity
- use ndb set_sub_cb to receive sub update notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants