Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #20

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Windows support #20

merged 9 commits into from
Nov 28, 2024

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Nov 23, 2024

jb55 added 3 commits November 27, 2024 10:05
@jb55
macos: enable framework stuff
9c6c605 
not sure why this is commented out

Signed-off-by: William Casarin <[email protected]>
@jb55
note: explicit clone implementation
def93dc 
This is needed to handle owned version of our notes and
to fix CI

Signed-off-by: William Casarin <[email protected]>
@jb55
fmt: formatting and clippy
7fc1c74 
Signed-off-by: William Casarin <[email protected]>
@jb55 jb55 force-pushed the windows branch 3 times, most recently from fee51c6 to 8d96dbd Compare November 27, 2024 18:47
@jb55
Copy link
Contributor Author

jb55 commented Nov 27, 2024

@kernelkind @ksedgwic does cargo test work for you on this branch for your systems? I tested on macOS, windows and linux and its all green, but CI still doesn't like it for some reason

@ksedgwic
Copy link

I'm broken on fedora 38:

  = note: /usr/bin/ld: /home/user/bonsai/nostrdb-rs/target/debug/build/nostrdb-718f5ae394b2418e/out/libnostrdb.a(c2ae4883c7b9641b-nostrdb.o): in function `ndb_note_verify':
          /home/user/bonsai/nostrdb-rs/nostrdb/src/nostrdb.c:1658: undefined reference to `secp256k1_xonly_pubkey_parse'
          /usr/bin/ld: /home/user/bonsai/nostrdb-rs/nostrdb/src/nostrdb.c:1662: undefined reference to `secp256k1_schnorrsig_verify'
          /usr/bin/ld: /home/user/bonsai/nostrdb-rs/target/debug/build/nostrdb-718f5ae394b2418e/out/libnostrdb.a(c2ae4883c7b9641b-nostrdb.o): in function `ndb_sign_id':
          /home/user/bonsai/nostrdb-rs/nostrdb/src/nostrdb.c:4977: undefined reference to `secp256k1_context_create'
          /usr/bin/ld: /home/user/bonsai/nostrdb-rs/nostrdb/src/nostrdb.c:4979: undefined reference to `secp256k1_schnorrsig_sign32'
          /usr/bin/ld: /home/user/bonsai/nostrdb-rs/target/debug/build/nostrdb-718f5ae394b2418e/out/libnostrdb.a(c2ae4883c7b9641b-nostrdb.o): in function `ndb_create_keypair':

@jb55
Copy link
Contributor Author

jb55 commented Nov 28, 2024

is this broken in notedeck ? It's now merged in master

@jb55 jb55 force-pushed the windows branch 4 times, most recently from 870f191 to aac7143 Compare November 28, 2024 18:01
jb55 added 4 commits November 28, 2024 10:03
@jb55
win: use separate bindings for windows
41132c2 
since there are different data layouts
@jb55
build: ensure we build secp first
3c2822a 
maybe this is the issue

Signed-off-by: William Casarin <[email protected]>
@jb55
rustfmt and clippy time
ba909cf 
Signed-off-by: William Casarin <[email protected]>
@jb55
multi-platform build
3edec24 
Signed-off-by: William Casarin <[email protected]>
@jb55 jb55 force-pushed the windows branch 6 times, most recently from 74c47a4 to 6c66039 Compare November 28, 2024 18:19
@jb55
build: just include secp256k1 directly into nostrdb
e61a569 
should fix build issues

Signed-off-by: William Casarin <[email protected]>
@jb55
Copy link
Contributor Author

jb55 commented Nov 28, 2024

@ksedgwic thanks! figured it out. also added a multi-os CI build as well.

@jb55 jb55 merged commit c946dcf into master Nov 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jb55 @ksedgwic